Enahncement/renamed request analyzer methods #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +179,7 @@ public function getCurrentPostParameter() | |||
| * Returns the get parameters | |||
| * @return array | |||
| */ | |||
| public function getCurrentGetParameter() | |||
| public function getGetParameters() | |||
There was a problem hiding this comment.
Why do we do this? It is wrong
These parameters are only used by the ExceptionHandler as far as I can tell.
|
Please add this change to UPGRADE.md requestAnalyzer is used in some projects in the Client services/controllers |
|
ack |
dantleech
force-pushed
the
enahncement/renamed_request_analyzer_methods
branch
from
79eac64 to
e482170
Compare
|
Added CHANGELOG and UPGRADE. Ready to merge /cc @chirimoya |
|
@wachterjohannes @danrot can you approve this? then I will rebase and merge. (the test failure is due to the contact tests, not related). |
|
@dantleech i think someone of use should review it and merge it after release on monday! |
| @@ -2,8 +2,10 @@ CHANGELOG for Sulu | |||
| ================== | |||
|
|
|||
| * dev-develop | |||
|
|
|||
There was a problem hiding this comment.
we don't put new lines in these lists
|
If the tests are running after the rebase it is fine for me. |
- Renamed getCurrentMatchType - Renamed getCurrentWebspace - Renamed getCurrentPortal* - Renamed getCurrentSegment - Renamed getCurrentRedirect - Renamed getCurrentResourceLocator* - Renamed getCurrentGet|PostParameter - Renamed getCurrentAnalyticsKey
dantleech
force-pushed
the
enahncement/renamed_request_analyzer_methods
branch
from
e482170 to
8c59f64
Compare
dantleech
added a commit
that referenced
this pull request
Feb 10, 2015
…lyzer_methods Enahncement/renamed request analyzer methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames all of the methods in the RequestAnalyzerInterface which begin with
getCurrent.Fixes #170